Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VdcActionParameterBase.httpSessionId ...................................................................... core: Remove VdcActionParameterBase.httpSessionId httpSessionId in VdcActionParameterBase is a private field that isn't initialized in the constructor and has no set method. I.e., it is always null. Since it's actually a constant, there is no reason to hold it. This patch removes the field and all its references. That refactoring, in turn allows cleaning up login and logout flows a bit, as they have code that only fires when this member is not null. Change-Id: I239d13175a511291def1eb31ce55be17f376bf42 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LogoutUserCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java 3 files changed, 4 insertions(+), 44 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I239d13175a511291def1eb31ce55be17f376bf42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>