Eli Mesika has submitted this change and it was merged. Change subject: db: cleanup: trivial issues and bashism removal ...................................................................... db: cleanup: trivial issues and bashism removal 1. remove bash specific usage, will enable us to drop bash dependency from product. 2. cleanup non consistent indents. 3. add {} all over. 4. add "" all over. 5. add local whenever possible. 6. proper cleanup of temporary files. 7. remove unused DEBUG. 8. misc trivial fixups. 9. argument reorg. no change in functionality. tested with dash and bash. Change-Id: I6e937b290ad966e9d574596f4ca4a7c6c4292a43 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com&gt; --- M README.developer M packaging/dbscripts/cleandb.sh M packaging/dbscripts/create_schema.sh M packaging/dbscripts/dbcustomfunctions.sh M packaging/dbscripts/dbfunctions.sh M packaging/dbscripts/refreshStoredProcedures.sh M packaging/dbscripts/unlock_entity.sh M packaging/dbscripts/upgrade.sh M packaging/setup/dbutils/changedbowner.sh M packaging/setup/dbutils/common.sh M packaging/setup/dbutils/encodingvalidator.sh M packaging/setup/dbutils/fkvalidator.sh M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/validatedb.sh 14 files changed, 651 insertions(+), 708 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e937b290ad966e9d574596f4ca4a7c6c4292a43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org