Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: 'async' URL Parameter Malfunction (#957452)
......................................................................
restapi: 'async' URL Parameter Malfunction (#957452)
If 'async' param appears in URL, then, regardless of the value assigned to it
(true/false),
the application would, erroniously, always consider it true. After the change,
'async=true', 'async' are considered true,
'async=false' or the absence of this parameter are considered false, and an
illegal value ('async=blabla') throws exception.
Change-Id: I8b8ac5d49823612300f1c7872c8d317a20e02797
Bug-Url:
http://bugzilla.redhat.com/957452
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M
backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
A
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/exception/UrlParamException.java
5 files changed, 52 insertions(+), 7 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/15094
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b8ac5d49823612300f1c7872c8d317a20e02797
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>