Oved Ourfali has submitted this change and it was merged. Change subject: tools: add snmp oid validation. ...................................................................... tools: add snmp oid validation. An oid is valid iff 2 <= size() <= 128 and if the first two sub-identifiers are less than 3 and 40 respectively. Emtpy values are not valid. a missing value already generates an exception when getting property. Change-Id: I2469bfac312eb38dad7de093c8fefe144f75bbb2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073498 Signed-off-by: Mooli Tayer <mtayer@redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2469bfac312eb38dad7de093c8fefe144f75bbb2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: mooli tayer <mtayer@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server