Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: DB configuration plugin ...................................................................... packaging: setup: DB configuration plugin Motivation A setup may fail with misconfigured db properties, but it fails-fast, and that may send the user into a loop untill all the db values are configured correctly while instead we can report all the missing items at once and offer to fix them Change Default configuration are decleared by the core setup files and extra configuration are inside configuration.py Whenever a configuration item is decleraed as must, the setup will try to fix ammend postgres.conf and restart postgres (notice, won't work for dev-env unless combind with sudo). If the db is a remote db, the user will get a warning with the misconfigured items and setup will abort Result Setup can auto fix mandatory db configurations without asking for manual intervention. Change-Id: I99d5a661044a4077589326b8f215fa2152952304 Bug-Url: https://bugzilla.redhat.com/1388433 Signed-off-by: Roy Golan <rgolan(a)redhat.com&gt; --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/engine_common/constants.py M packaging/setup/ovirt_engine_setup/engine_common/database.py M packaging/setup/ovirt_engine_setup/engine_common/dwh_shared_constants.py M packaging/setup/ovirt_engine_setup/engine_common/postgres.py M packaging/setup/ovirt_engine_setup/provisiondb/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/configuration.py 8 files changed, 348 insertions(+), 128 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Peřina: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/72111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d5a661044a4077589326b8f215fa2152952304 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;