Allon Mureinik has submitted this change and it was merged. Change subject: engine: Ties more consistently between vm disk device and disk entities. ...................................................................... engine: Ties more consistently between vm disk device and disk entities. VmDevice is the model entity on the Engine that ties between VM and the disk attached to this VM. Disk is not the only entity which tied to VM by VmDevice, but the only to be affected by this patch. VmDevice keeps a few very important characteristics of the underlying disk, for example address which ties the disk to specific slot of the controller. Without that information or if this information is not consistent disk may become useless after being introduced to the VM. During creating VM from a template with Disks A and B. Disk A => Disk A' Disk B => Disk B' So, if VMDevice A ties between Disk A and Template then VmDevice A' should tie between newly created VM and Disk A'. This patch make this process more consistent as till now, Engine was up to the order of disks in the Map or List as they were retrieved from UI or Database. Change-Id: I8bf284ea4e05f03fc0a7e94a1ec901aacbdc1ab1 Bug-Url: https://bugzilla.redhat.com/993776 Signed-off-by: Sergey Gotliv <sgotliv@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 6 files changed, 49 insertions(+), 54 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bf284ea4e05f03fc0a7e94a1ec901aacbdc1ab1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Haim Ateya <hateya@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server