Change in ovirt-engine[ovirt-engine-4.1]: webadmin: add error indication to invalid VM name

From Tal Nisan <tnisan@redhat.com>:
Tal Nisan has submitted this change and it was merged. Change subject: webadmin: add error indication to invalid VM name ...................................................................... webadmin: add error indication to invalid VM name When importing a VM there was no indication of an invalid VM name in the general sub tab, this patch adds a highlight with the information in the tooltip by changing the UI element to StringEntityModelTextBoxOnlyEditor which has validation unlike the previous TextBoxChanger. Change-Id: Ia6484840460ea05f8e186f410b89c58b39d0d79d Bug-Url: https://bugzilla.redhat.com/1403578 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Benny Zlotnik: Verified Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6484840460ea05f8e186f410b89c58b39d0d79d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review