Tal Nisan has submitted this change and it was merged. Change subject: vdsbroker: mark vds as spm candidate before connectStoragePool ...................................................................... vdsbroker: mark vds as spm candidate before connectStoragePool When we assign the spm role we first perform connectStoragePool() to make sure that the host has the latest pool metadata. If connectStoragePool fails on the master domain being unavailable we'll attempt to perform failover (start the spm on a different host) if there are more hosts in the data center. When there are no more candidate hosts for the spm role reconstruct will be performed. Because the failure is on the connect operation, the host won't be marked as the current candidate for the spm rule which will prevent failover from running, causing for reconstruct to not be executed. Change-Id: I65a44d9c42782ea27aa257e5b53ccb70c9dbcca8 Bug-Url: https://bugzilla.redhat.com/1397861 Signed-off-by: Liron Aravot <laravot(a)redhat.com&gt; --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/68931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65a44d9c42782ea27aa257e5b53ccb70c9dbcca8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;