Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Simplify use of generics to avoid cobertura bug ...................................................................... core: Simplify use of generics to avoid cobertura bug The use of nested generic types as method return types seems to trigger a bug in cobertura. First detected case is the following line in DBConfigUtils: return this.<Map<?, ?>> GetValue(...); It generates the following error: "org.ovirt.engine.core.dal.dbbroker.generic.DBConfigUtils.GetValue(DataType,String,String)" [cobertura-report] Encountered " "?" "? "" at line 239, column 30. [cobertura-report] Was expecting one of: [cobertura-report] "assert" ... [cobertura-report] "boolean" ... ... In this particular case we can remove that line without affecting the rest of the code. Change-Id: Ie29ff2a0314713a7c49fd3c9fee0b909ad0553f8 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java 1 file changed, 3 insertions(+), 14 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie29ff2a0314713a7c49fd3c9fee0b909ad0553f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Eyal Edri <eedri@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>