Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: refactored out updateActionTypeForQosType method ...................................................................... restapi: refactored out updateActionTypeForQosType method • this code does not belong into update/add method (also making it overgrown) • not initializating 'updateActionType' variable causes NPE much later in process without sensible explanation. Bug-Url: https://bugzilla.redhat.com/1249654 Change-Id: Ic16d1488a932b49a4fedea3247c2e00cf06f6c5c Signed-off-by: Martin Mucha <mmucha(a)redhat.com&gt; --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQosResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosTypeMapper.java 4 files changed, 105 insertions(+), 48 deletions(-) Approvals: Ori Liel: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic16d1488a932b49a4fedea3247c2e00cf06f6c5c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com&gt; Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com&gt; Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org