Change in ovirt-engine[master]: core: minor cleanup in MigrateVmToServerCommand

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor cleanup in MigrateVmToServerCommand ...................................................................... core: minor cleanup in MigrateVmToServerCommand - remove var_action and var_type settings which are already set in MigrateVmCommand#setActionMessageParameters - call failCanDoAction instead of having nested if-else statements - move comment that explains a method to be right before the method instead of inside the method body Change-Id: Ic455ae7ba1a38cd8d7e67e4d925d2ce18493227a Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java 1 file changed, 15 insertions(+), 16 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic455ae7ba1a38cd8d7e67e4d925d2ce18493227a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server
participants (1)
-
ofrenkel@redhat.com