Oved Ourfali has submitted this change and it was merged. Change subject: tools: Add runtime log4j setup to engine-manage-domains ...................................................................... tools: Add runtime log4j setup to engine-manage-domains 1) Moves default log4j.xml for engine-manage-domains into tools.jar 2) By default logging is off 3) Adds --log-file which sets file to write logging messages into 4) Adds --log-level which sets logging level for logger specified with --log-file (it's set to INFO by default) 5) Adds --log4j-config which sets filename or URL with custom log4j.xml file to setup logging Change-Id: I0641dd6ce8984504c8c6e97df7b90e81ca5a8c4f Bug-Url: https://bugzilla.redhat.com/1083411 Signed-off-by: Martin Perina <mperina@redhat.com> --- M Makefile M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsExecutor.java A backend/manager/tools/src/main/resources/engine-manage-domains/log4j.xml M backend/manager/tools/src/main/resources/manage-domains-help.properties M ovirt-engine.spec.in M packaging/bin/engine-manage-domains.sh D packaging/etc/engine-manage-domains/log4j.xml.in M packaging/man/man8/engine-manage-domains.8 10 files changed, 146 insertions(+), 89 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0641dd6ce8984504c8c6e97df7b90e81ca5a8c4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server