Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin,userportal: error in custom properties sheet ...................................................................... webadmin,userportal: error in custom properties sheet Current custom properties sheet doesn't handle cases where there are no properties stored in DB. Extracting the new duplicate code (splitting logic) into AsyncDataProvider Change-Id: Ia939952c367b6416ed90bb295f1485ce4ac63368 Bug-Url: https://bugzilla.redhat.com/924201 Signed-off-by: Gilad Chaplik <gchaplik@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 5 files changed, 42 insertions(+), 57 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia939952c367b6416ed90bb295f1485ce4ac63368 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com>