Allon Mureinik has submitted this change and it was merged. Change subject: core: ProcessOvfUpdateForStorageDomainCommand's comparators test ...................................................................... core: ProcessOvfUpdateForStorageDomainCommand's comparators test Add a test for ProcessOvfUpdateForStorageDomainCommand's comparator. This patch also produces a (very, VERY) slight performance improvement as the comparator, which is stateless anyway, can be created once and saved instead of creating a new instance of an anonymous class each processing iteration. Change-Id: If8d87c6b4e89711ae052727207c07527c9039a4f Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommandComparatorTest.java 2 files changed, 61 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8d87c6b4e89711ae052727207c07527c9039a4f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>