Eli Mesika has submitted this change and it was merged. Change subject: db:add tab/col name validation to common functions ...................................................................... db:add tab/col name validation to common functions No error thrown in common_sp functions in case column or table does not exists. This patch adds validations to drop/change type/rename column common functions in order to prevent the setup continue in case that there was an error in the table/column name. This patch also fix some upgrade scripts that used invalid/non-existing column names. Change-Id: Iba5f087f3d47b4f36bb99151a21c2e1016d77b64 Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1141829 Signed-off-by: Eli Mesika <emesika@redhat.com> --- M packaging/dbscripts/common_sp.sql M packaging/dbscripts/upgrade/03_03_0060_drop_desktop_device.sql M packaging/dbscripts/upgrade/03_03_0380_remove_auto_suspend.sql M packaging/dbscripts/upgrade/03_03_0710_add_profile_to_network_interface.sql 4 files changed, 14 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba5f087f3d47b4f36bb99151a21c2e1016d77b64 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Shirly Radco <sradco@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server