Eli Mesika has submitted this change and it was merged. Change subject: engine: SearchQuery generates slow query on vds_with_tags and storage_domains ...................................................................... engine: SearchQuery generates slow query on vds_with_tags and storage_domains Fix SearchQuery so that queries without tags are run against the base table, saving an uneeded (and costly) inner query. VDS query decreased by almost 80% (from 100ms to 15ms). Change-Id: Ia0b7a4912d031c4cdafd636126730ea81d8d2bdd Bug-Url: https://bugzilla.redhat.com/984973 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 3 files changed, 93 insertions(+), 29 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0b7a4912d031c4cdafd636126730ea81d8d2bdd Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server