Change in ovirt-engine[master]: webadmin: change cd dropdown

From Alexander Wels <awels@redhat.com>:
Alexander Wels has submitted this change and it was merged. Change subject: webadmin: change cd dropdown ...................................................................... webadmin: change cd dropdown - Fixed issue where the change cd dropdown would be stuck inside the dialog and you would have to scroll to see cds. - Fixed NPE when the VM didn't have a previous CD in it. Change-Id: I95b700071519befa71e233d9f8d3ccc3fc11519f Bug-Url: https://bugzilla.redhat.com/1434148 Signed-off-by: Alexander Wels <awels@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundWidgetPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmChangeCDPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmChangeCDPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AttachCdModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmChangeCDPopupView.java 6 files changed, 12 insertions(+), 32 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95b700071519befa71e233d9f8d3ccc3fc11519f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review