Allon Mureinik has submitted this change and it was merged. Change subject: core: Add a unit test for queries constructors ...................................................................... core: Add a unit test for queries constructors Following the previous patches that streamlined the queries to all have two-argument constructors, this patch extracts the common functionality of testing constructors from CommandCtorsTest and introduces a similar test to make sure all the queries are defined correctly. Change-Id: Ia69475e7256e591a088c0656a961984237195a01 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandCtorsTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CtorsTestBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCtorsTest.java 3 files changed, 235 insertions(+), 155 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77117 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia69475e7256e591a088c0656a961984237195a01 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;