Maor Lipchuk has submitted this change and it was merged. Change subject: core: use return value instead of a shared boolean in recovery ...................................................................... core: use return value instead of a shared boolean in recovery This patch adds the use of return value to return whether reconstruct command got to execute ReconstructMasterVDS, rather then use a shared boolean - this allows also to execute reconstruct from recovery as internal command rather then super.execute() which is less trivial and can cause to some issues. NOTE: execution of reconstruct from recovery was reverted in commit I9423d880a7d10a5bfa917e415fe41651f9d7e7f1 because of some issues that it caused, this patch fixes those issues. Change-Id: I880361ebe3f23a098a4ede760310c1f0148ae5c6 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java 2 files changed, 28 insertions(+), 19 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I880361ebe3f23a098a4ede760310c1f0148ae5c6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Ayal Baron <abaron@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com>