Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Overload ListModel.setItems() with selectedItem ...................................................................... webadmin: Overload ListModel.setItems() with selectedItem Added an overload that includes an argument specifying the desired selectedItem after the items are set; previously this was being set to null, which could cause problems if the ListModel is associated with an editor that implements HasConstrainedValue (because then UiCommonEditorVisitor would override the null value and select the first item in the collection). Change-Id: Id6de644297cdd5eb965720fc64aea1a5a735ea24 Bug-Url: https://bugzilla.redhat.com/1070835 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/26231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6de644297cdd5eb965720fc64aea1a5a735ea24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server