Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove unused VdsmErrors ...................................................................... engine: Remove unused VdsmErrors Similarly to d9a87e52e9727d9bb5a1ca7f7425aaaf4fd97503, this patch cleans up redundant messages from VdsmErrors.properties and VdsmErrors.java files. This patch contains: - Refactoring AbstractPropertiesTestBase so it receives the enum to check against as a parameter instead of hard-coded in the class. - Add new EngineErrorsTest test classes in dal, webadmin and frontend modules. - Remove unused error messages from frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.propertie Change-Id: I0e39c94499a3a05020bdb87e643849e1b6680f34 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/EngineErrorsTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/ErrorMessagesTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AbstractPropertiesTestBase.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties A frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/EngineErrorsTest.java M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ErrorMessagesTest.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties A frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/EngineErrorsTest.java M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ErrorMessagesTest.java 11 files changed, 43 insertions(+), 43 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e39c94499a3a05020bdb87e643849e1b6680f34 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org