Eli Mesika has submitted this change and it was merged.
Change subject: core: fixing a problem in upgrade
......................................................................
core: fixing a problem in upgrade
The last rename of "vds group" to cluster caused a problem in schema.py
on upgrade, at that point, the script looking for cluster versions does
not have the cluster table and need to use vds_groups.
Solution was adding in an upgrade script a view named vds_groups that
only selects the original cluster table records and revert schema.py to
relate to vds_groups.
This is done in an upgrade script and not in create_views.sql since
eventually when this code will be squashed to the base DB, we will drop
this vds_groups view.
The reason why this error was not found by CI tests is that upgrade jobs
are using schema.sh script directly and not engine-setup which seems to
be problematic.
Change-Id: If230d3cd397c314a27cc78d3837b637b671ba706
Signed-off-by: emesika <emesika(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0210_add_vds_group_view.sql
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Passed CI tests
Daniel Erez: Verified; Looks good to me, approved
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/51784
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If230d3cd397c314a27cc78d3837b637b671ba706
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>