Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Proper VM SystemTab Validation ...................................................................... frontend: Proper VM SystemTab Validation UnitVmModel#validate() used async query to get max valid mem size and thus caused race with submiting the Vm dialog so the memory was not validated at all. Added missing validation for whole SystemTab. Removed unused AsyncDataProvider methods to get various memory-limit related ConfigValues and corresponding (also unused) UnitVmModel fields. Added support for TB memory size in MemorySizeParser and disabled parsing of garbled input '12a30 MB' as longest valid prefix ('12 MB'). Removed ByteSizeValidation since it didn't validate anything. It validated only String entities and the memory size is an EntityModel<Integer>. All validation is performed in validateMemorySize in conjuction with MemorySizeParser. Change-Id: I33761ac7c5491c17fff928de13fdf16065d47e1e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069628 Signed-off-by: Martin Betak <mbetak@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/parser/MemorySizeParser.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ByteSizeValidation.java 5 files changed, 51 insertions(+), 198 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/26268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33761ac7c5491c17fff928de13fdf16065d47e1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server