Maor Lipchuk has submitted this change and it was merged. Change subject: core:Support remove of shareable disk. ...................................................................... core:Support remove of shareable disk. The following patch has the following changes: 1.Adding support to remove disk from multiple vms. The remove command was counting on the vm id which was in the disk. After this change the vmId will be fetched from the DB. 2.Update vm device store procedures to use vmId as a parameter when remove or getting a vm device. This is neccessery for the Activate/Deactivate process to work for shareable disk. 3.Update the lock mechanism in the remove disk command to log the VMs which are using in the shared lock, and also change the aquire lock to be at the end of the CDA instead before the validation. Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> Change-Id: Idde509a7bdee94e6fd481fce510b26f89d6b0429 --- M backend/manager/dbscripts/vm_device_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 3 files changed, 54 insertions(+), 29 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idde509a7bdee94e6fd481fce510b26f89d6b0429 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com>