Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix NPE when live migrating a disk ...................................................................... restapi: Fix NPE when live migrating a disk Empty Guid was passed as source domain id to the MoveDisksCommand and onward. This is fixed and the actual source domain is extracted from the disk entity when moving/migrating/copying a disk. The source domain id is then used in the parameters classes. This was mocked out in the relevant tests. Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Bug-Url: https://bugzilla.redhat.com/1124321 Signed-off-by: Vered Volansky <vvolansk@redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java 4 files changed, 31 insertions(+), 6 deletions(-) Approvals: Ori Liel: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/31339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Ori Liel <oliel@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server