Tal Nisan has submitted this change and it was merged. Change subject: core: encode non-ASCII disk alias/description ...................................................................... core: encode non-ASCII disk alias/description Patch Ie2642ae7 causes the disk alias and description to be stored in the disk's metadata. Since vdsm expects for ASCII characters only, and since both fields can contain non-ASCII characters, the operation fails on vdsm. This patch encodes these fields if they contain non-ASCII characters using HEX encoding (and decodes when reading them), so that vdsm can handle these fields even if they contain non-ASCII characters. Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e Bug-Url: https://bugzilla.redhat.com/1249130 Bug-Url: https://bugzilla.redhat.com/1219680 Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java 3 files changed, 205 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Maor Lipchuk: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/45374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Adam Litke <alitke@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org