Moti Asayag has submitted this change and it was merged. Change subject: engine: Use an ancestor type in Entities helper class ...................................................................... engine: Use an ancestor type in Entities helper class There is no reason to limit the signature of Entities.hostInterfacesByNetworkName(List) to get list only, since Collection type is suiable as well in that context. The motivation is to allow other caller that would like to provide the Collection type to benefit of this method without need to cast it first to List. Change-Id: I28e2d22feced3a615393fc3c1cf80ea087888f61 Signed-off-by: Moti Asayag <masayag@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28e2d22feced3a615393fc3c1cf80ea087888f61 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server