Roy Golan has submitted this change and it was merged. Change subject: core: Fix detection of preferred hosts for numa nodes ...................................................................... core: Fix detection of preferred hosts for numa nodes This fixes two things: When adding new numa nodes through the rest api or the numa support dialog in the host context menu, the detection of the preferred hosts failed in AddVmNumaNodesCommand#canDoAction. When creating or updating VMs, the first time the admin switched to "non migratable", the detection of the preferred hosts failed. This led to the situation where the whole VM was created, except for the numa nodes. When updating a VM all numa nodes were deleted and could not be added again. So the whole numa configuration disappeared. Bug-Url: https://bugzilla.redhat.com/1248049 Bug-Url: https://bugzilla.redhat.com/1256725 Change-Id: I1f72bbe131402f2037f6083c236864b5a2d3ac62 Signed-off-by: Roman Mohr <rmohr@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java 2 files changed, 141 insertions(+), 1 deletion(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f72bbe131402f2037f6083c236864b5a2d3ac62 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir@redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: automation@ovirt.org