Change in ovirt-engine[master]: webadmin: icon upload info icon

From Alexander Wels <awels@redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80364 ) Change subject: webadmin: icon upload info icon ...................................................................... webadmin: icon upload info icon - Fixed issue where the alert message box would not disappear when you corrected the problem. - Removed InfoIcon extra css which is now provided by PF - Fixed positioning issue with info icon on upload icon. - Replaced upload icon buttons to be bootstrap buttons. - Removed unnecessary key handler implementation on icon upload. Change-Id: I3d8d6836ab67939173c3dfa01c430c5dfa00cd06 Signed-off-by: Alexander Wels <awels@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/InfoIcon.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/CompositeHandlerRegistration.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.ui.xml D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/InfoIcon.css 6 files changed, 9 insertions(+), 99 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d8d6836ab67939173c3dfa01c430c5dfa00cd06 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review