Omer Frenkel has submitted this change and it was merged. Change subject: core: graphicsProtocol in changed fields list ...................................................................... core: graphicsProtocol in changed fields list After editing parameters of a running VM, list of changed fields that will be updated on the next run is displayed to user. Graphics devices are presented in this list as separate devices (SPICE and VNC) while corresponding to the single field in the UI ("Graphics protocol"). To correct this, 'name' parameter was introduced into @EditableDeviceOnVmStatusField annotation. If it is present, its value will be displayed to the user in the changed fields list, instead of device type name. If two devices have the same name, it will be included into the list only once. This allows, in our case, to present SPICE and VNC devices as single 'graphicsProtocol' field. Change-Id: I95facdae456ca904f1e0d1ece32a96658992b2eb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238742 Signed-off-by: Shmuel Melamud <smelamud@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EditableDeviceOnVmStatusField.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceUpdate.java 5 files changed, 42 insertions(+), 25 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95facdae456ca904f1e0d1ece32a96658992b2eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: automation@ovirt.org