Maor Lipchuk has submitted this change and it was merged. Change subject: core: Refactor, Use RemoveCinderVolumeParentCommand method. ...................................................................... core: Refactor, Use RemoveCinderVolumeParentCommand method. Make RemoveCinderDiskCommand to use methods from the parent command. The difference in the parent command is that we also pass the storage id of the volume. Change-Id: I49ebcbfff3b584e39d20dec0b686e2879e30d650 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommandCallback.java 2 files changed, 7 insertions(+), 129 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49ebcbfff3b584e39d20dec0b686e2879e30d650 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>