Keith Robertson has submitted this change and it was merged. Change subject: tools: fixed command line parser setup ...................................................................... tools: fixed command line parser setup The previous command line parser setup caused the rewrite of the database connection parameters read from .pgpass with the hardcoded defaults each time the command line was parsed. This caused a failure while collecting PostgreSQL database configuration when using a remote setup Now the script check if we have root permission, then read .pgpass setting the default values for the command line parser. In order to figure out what was happening, I added some logging to the __main__ module and to the posgresql sos plugin. Change-Id: I284554888143ad27bca0630cdbc26e91cf735ab9 Bug-Url: https://bugzilla.redhat.com/885421 Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com> --- M src/__main__.py M src/sos/plugins/postgresql.py 2 files changed, 98 insertions(+), 70 deletions(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I284554888143ad27bca0630cdbc26e91cf735ab9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Alex Lourie <alourie@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com>