From Martin Peřina <mperina@redhat.com>:

Martin Peřina has submitted this change and it was merged. Change subject: core: Remove failure reasons from EngineLock#toString ...................................................................... core: Remove failure reasons from EngineLock#toString EngineLock#toString prints the validation failure that should be used if the lock cannot be acquired. This leads to INFO messages about successful lock acquisitions to seem, at first glance, as error messages, which is confusing (see, e.g., the attached bug). This patch suggests improving the logs by NOT printing the validation messages, which will only be printed (and only be useful) if the engine fails to acquire the lock. Change-Id: I6ffc9107f67ffe5896e1a61b5a4511b83168c26e Bug-Url: https://bugzilla.redhat.com/1454843 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/EngineLock.java 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/78054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ffc9107f67ffe5896e1a61b5a4511b83168c26e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>