Eli Mesika has submitted this change and it was merged. Change subject: core: VmDevice implements comparable(#852451) ...................................................................... core: VmDevice implements comparable(#852451) Changed VmDevice to implement Comprable interface. The comparison is based on Id comparing. Id is composed from deviceId and vmId, so the Id comparison algorithm checks: a. compareTo on vmId fields. b. (if result is not 0) compareTo on deviceId fields Change-Id: Ic82521368a4f3c3c518c8cf4e5dc460b9e54f379 Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceId.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmDeviceTest.java 3 files changed, 75 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic82521368a4f3c3c518c8cf4e5dc460b9e54f379 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>