Arik Hadas has submitted this change and it was merged. Change subject: core: refactoring in SchedulingManager ...................................................................... core: refactoring in SchedulingManager SchedulingManager#schedule used have too many responsibilities - input validation, best host selection, update pending resources, and cluster locks handling. This patch extract the best host selection to separate method to remove one of the responsibilities mentioned above and simplify the code. In addition, other minor refactoring was made in this class. Change-Id: I57b8e4751b4da329658f4b8e1ae2366b1147a137 Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 53 insertions(+), 47 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57b8e4751b4da329658f4b8e1ae2366b1147a137 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com&gt; Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com&gt; Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server