From Tal Nisan <tnisan@redhat.com>:

Tal Nisan has submitted this change and it was merged. Change subject: core: Free pooled VM lock independently from context locks ...................................................................... core: Free pooled VM lock independently from context locks When a non-prestarted VM is allocated from VM Pool, it is locked early in AttachUserToVmFromPoolAndRunCommand flow, before other locks of the command are taken. It is possible that it is also freed before that moment, so context.getLock() != null condition will be false, but the VM lock is already taken and must be freed. Change-Id: I628946d781ecbe280562efe7cf7e3a3c84801f39 Bug-Url: https://bugzilla.redhat.com/1433924 Bug-Url: https://bugzilla.redhat.com/1432105 Signed-off-by: Shmuel Melamud <smelamud@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachUserToVmFromPoolAndRunParameters.java 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I628946d781ecbe280562efe7cf7e3a3c84801f39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>