Liron Aravot has submitted this change and it was merged. Change subject: core: commands in EXECUTION_FAILED status might have running childs ...................................................................... core: commands in EXECUTION_FAILED status might have running childs When the command status is EXECUTION_FAILED the command might still have running child commands, there command shouldn't be considered as ended until all of its child commands were ended. Currently not all callbacks has the appropiate handling to that status and its sometimes assumed that a child command on that status was ended with failure. This patch adds pollOnExecutionFailed() to indicate whether doPolling() should be executed for the command if its on EXECUTION_FAILED status untill all the callbacks will inheirt from the same base callback. Change-Id: I713b4d179316e056466d402fe3201fad5666b849 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallback.java 3 files changed, 22 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I713b4d179316e056466d402fe3201fad5666b849 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>