Martin Peřina has submitted this change and it was merged. Change subject: core: Optimize equals/hashCode in virt classes ...................................................................... core: Optimize equals/hashCode in virt classes 1. Optimizes equals method to contain recommended functionality as described in Effective Java 2nd edition 2. Optimizes objects comparison in equals method to use Objects.equals() 3. Optimizes hashCode method to use Objects.hash()/hashCode() methods Change-Id: I28c8cc7c37f32b3d757202c432a443f80a0696df Signed-off-by: Martin Perina <mperina@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmToServerParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDeviceId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDeviceView.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OvfEntityData.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ServerCpu.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UserProfile.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/V2VJobInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBlockJob.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceId.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmIcon.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmIconDefault.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJob.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPoolMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IconWithOsDefault.java 25 files changed, 409 insertions(+), 478 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28c8cc7c37f32b3d757202c432a443f80a0696df Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>