Moti Asayag has submitted this change and it was merged. Change subject: core: locking proxy must lock pool and not decorator. ...................................................................... core: locking proxy must lock pool and not decorator. it occured to me, that we must block concurrent access into decorators, however opposite is true. Concurrent access in decorators is not a problem in current implementation, however having locking proxy on top means, that decorators have extra access into the pool bypassing synchronization, which does cause a problem. Change-Id: I6e25394f00cbb6fe5dbc61886c2955f953db455f Bug-Url: https://bugzilla.redhat.com/1395462 Signed-off-by: Martin Mucha <mmucha(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DelegatingMacPoolDecorator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactoryTest.java 3 files changed, 65 insertions(+), 79 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e25394f00cbb6fe5dbc61886c2955f953db455f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com&gt; Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com&gt; Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;