Tal Nisan has submitted this change and it was merged. Change subject: core: fix removal of attached disks to stateless vm ...................................................................... core: fix removal of attached disks to stateless vm Change the way we handle disks when stateless VM goes down, to prevent situations where disks are being removed. This might happen when disk is attached to stateless VM while it was running (hot-plug) so no snapshot was taken for it as part of the stateless snapshot of the VM, and when restoring the stateless snapshot we'll remove it. The solution is to find disks which don't have volumes attached to the stateless snapshot and to detach them from the VM before restoring the stateless snapshot. Change-Id: I3a1d6eb8d2f4606622c7ed5c73370792406bb9b3 Bug-Url: https://bugzilla.redhat.com/1174812 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java 2 files changed, 46 insertions(+), 12 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a1d6eb8d2f4606622c7ed5c73370792406bb9b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server