Tal Nisan has submitted this change and it was merged. Change subject: core: Unify similar methods in VdsBrokerObjectsBuilder ...................................................................... core: Unify similar methods in VdsBrokerObjectsBuilder The methods extractIntegerList and extracStringtList (sic) are doing exactly the same aside for the fact that one returns null when elements are not found and the second returns an empty list. Both methods were unified to a single method Change-Id: Iedfd72038d28e92b1fd078a8d5536c8334f70733 Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 11 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedfd72038d28e92b1fd078a8d5536c8334f70733 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>