Oved Ourfali has submitted this change and it was merged. Change subject: core: Distinguish between manual fence resulted.. ...................................................................... core: Distinguish between manual fence resulted.. Distinguish between manual fence resulted from user action and manual fence called internally by auto fence Manual fence currently can be executed in 2 flows 1) As part of the non responding treatment when host is restart via its PM agent. 2) As a result of a manual host stopping and choosing "confirm Host has been rebooted" from the right-click popup menu The messages generated by both to the log are of the format: Manual fence for host ${VdsName} was started. Manual fence for host ${VdsName} failed. When this occurs in scenario 1) above, the term "manual" in the audit log is confusing and should be changed to reflect the fact that was done internally by the engine code and not by the user This patch logs different messages to the audit log when resulted from scenario 1) above. Change-Id: I274ec95bb3f2c217bd9871afa9d761a1b975d793 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083750 Signed-off-by: Eli Mesika <emesika@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 3 files changed, 20 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I274ec95bb3f2c217bd9871afa9d761a1b975d793 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server