Oved Ourfali has submitted this change and it was merged. Change subject: engine : CommandBase should not set end status for commands with callback ...................................................................... engine : CommandBase should not set end status for commands with callback When mixing async tasks and async commands if a callback is provided by the command the CommandBase should not set the status of the command. The command should override endSuccessfully and endWithFailure to set the status of the async tasks status to succeeded or failed. Change-Id: I84c05917003376d2f62d3da7acecd889f8cb79e0 Bug-Url: https://bugzilla.redhat.com/1160872 Signed-off-by: Ravi Nori <rnori@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 39 insertions(+), 3 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c05917003376d2f62d3da7acecd889f8cb79e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server