Moti Asayag has submitted this change and it was merged. Change subject: engine: Require Permissions on Network ...................................................................... engine: Require Permissions on Network Actions that using Networks will require specific permissions for the subjected network: Network's usage actions require users to have an action group CONFIGURE_VM_NETWORK/CONFIGURE_TEMPLATE_NETWORK for using the network. In order to configure PORT_MIRRORING the user must have PORT_MIRRORING action group on the network. The patch assumes the network name might be empty for creating a vNic which isn't connected to any network (as part of the Network Wiring feature). Change-Id: Ife019f6195b8a8c09e7dba989f37f150700dbaea Signed-off-by: Moti Asayag <masayag@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateInterfaceCommand.java 4 files changed, 127 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife019f6195b8a8c09e7dba989f37f150700dbaea Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Muli Salem <msalem@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra@linux.vnet.ibm.com>