Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Import graphics devices from externally managed VMs
......................................................................
core: Import graphics devices from externally managed VMs
When importing the hosted engine VM or other external VMs we now import
the Graphics device (SPICE, VNC). Previously they were ignored because
they never get an address property.
Change-Id: I3a405df759b4c2fc624e79deb62aa39c5ac4d8e5
Bug-Url:
https://bugzilla.redhat.com/1326810
Bug-Url:
https://bugzilla.redhat.com/1328921
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
(cherry picked from commit 2647308822a84d2938d035d7471bf178e8c22d0b)
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommandTest.java
A backend/manager/modules/bll/src/test/resources/external_vm.json
A backend/manager/modules/bll/src/test/resources/he_vm.json
4 files changed, 685 insertions(+), 28 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/58255
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a405df759b4c2fc624e79deb62aa39c5ac4d8e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>