Moti Asayag has submitted this change and it was merged. Change subject: engine: refactor CollectVdsNetworkDataVDSCommand ...................................................................... engine: refactor CollectVdsNetworkDataVDSCommand Refactor CollectVdsNetworkDataVDSCommand: extract the network topology persistence logic into its own class with non-static methods. Change-Id: I798abe6597c06df873ac94f61981ff1dccc07bc8 Signed-off-by: Yevgeny Zaspitsky <yzaspits@redhat.com> Signed-off-by: Moti Asayag <masayag@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersister.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 4 files changed, 341 insertions(+), 291 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I798abe6597c06df873ac94f61981ff1dccc07bc8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server