Oved Ourfali has submitted this change and it was merged. Change subject: core: fix the fn_db_split_config_value db function and uses ...................................................................... core: fix the fn_db_split_config_value db function and uses Previous patch added the fn_db_split_config_value, to take general value, and update it with a newer one, splitting to versions. The previous implementation of the function updated the newest version to the input value, which will work well on upgrade, but not for new installations. New implementation of this function takes the version from which we need to split, and updates all the versions from it and byeond. Will work well for new installation (split general to the different versions), and for upgrades (new version, if there is one, will get the input value). Also, adding new supported secured spice channels (smartcard and usbredir), both to the config and to the config tool. Change-Id: I6964750ed0f57155e7c64a2a29ee0c21e2043410 Signed-off-by: Oved Ourfali <oourfali@redhat.com> --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 4 files changed, 17 insertions(+), 11 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6964750ed0f57155e7c64a2a29ee0c21e2043410 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com>