Eli Mesika has submitted this change and it was merged. Change subject: tools: notifier: Remove auxiliary email address from EventSender interface ...................................................................... tools: notifier: Remove auxiliary email address from EventSender interface Prior to this change the interface EventSender.java contained the following logic: an email address can come from wither The subscriber table(event_subscriber) or if it does not exist the user table (users). This patch moves this logic from the interface to the component loading the email subscriber, as this logic is email specific. Simpler interfaces are better. Change-Id: Ic69ff7541fca8347fb7cb85665934ca704fa9d06 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com&gt; --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/EventSender.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventSenderMailImpl.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/mail/MailSenderTest.java M packaging/dbscripts/create_views.sql 5 files changed, 37 insertions(+), 67 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic69ff7541fca8347fb7cb85665934ca704fa9d06 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server