Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Clean up interface cloning code
......................................................................
webadmin: Clean up interface cloning code
VdsNetworkInterface entities didn't seem to be cloned at all so that
code was removed, while the code cloning VmNetworkInterface was
modified to be called from copy constructors.
Change-Id: I1cfb4517ea2deb7fc6d5b49587c16b1d34026552
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkStatistics.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java
5 files changed, 34 insertions(+), 58 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/36464
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cfb4517ea2deb7fc6d5b49587c16b1d34026552
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server