Allon Mureinik has submitted this change and it was merged. Change subject: core: DiskImageDynamicDaoTest collcetions ...................................................................... core: DiskImageDynamicDaoTest collcetions Use Collections.singleton instead of Arrays.asList for single element collections. This achieves two goals: 1. A minute performance improvement 2. It better tests the API by passing a Set instead of List, thus adding another usecase. Change-Id: Ib2d2e6375fef8b8ecfae6a96324b52cd2559c082 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/57998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2d2e6375fef8b8ecfae6a96324b52cd2559c082 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>